Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release] Deprecate Freezable and frozenCopy. Resolves #11452 #11468

Merged
merged 2 commits into from
Jul 16, 2015
Merged

[BUGFIX release] Deprecate Freezable and frozenCopy. Resolves #11452 #11468

merged 2 commits into from
Jul 16, 2015

Conversation

jamiebuilds
Copy link
Contributor

Hold off on merging, putting this up so @stefanpenner can take a look.

Other stuff:

  • Can't get new freezable test file to run
  • frozenCopy still needs a test for the deprecation (the existing tests aren't actually run)

@mixonic
Copy link
Sponsor Member

mixonic commented Jun 15, 2015

Please also update the breaking changes list in the 2.0 beta blog post :-)

@jamiebuilds jamiebuilds mentioned this pull request Jun 15, 2015
Merged
@stefanpenner
Copy link
Member

@thejameskyle looks like this needs a rebase

@jamiebuilds
Copy link
Contributor Author

Rebased

@mixonic
Copy link
Sponsor Member

mixonic commented Jun 18, 2015

Darn it just kicked travis into submission, then noticed this is not flagged correctly. Please [BUGFIX release] so we can land it into 1.13.x

@jamiebuilds
Copy link
Contributor Author

I don't understand

@stefanpenner
Copy link
Member

@thejameskyle the commit message should be prefixed with '[BUGFIX release]` that way our magically build tool fairy (@rwjblue) knows where it must go.

@mixonic mixonic changed the title Deprecate Freezable and frozenCopy. Resolves #11452 [BUGFIX release] Deprecate Freezable and frozenCopy. Resolves #11452 Jun 18, 2015
@mixonic
Copy link
Sponsor Member

mixonic commented Jun 18, 2015

FYI The context for tagging commits is in: https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md#pull-requests

@stefanpenner
Copy link
Member

@thejameskyle I think packages/ember-runtime/tests/suites/copyable/frozenCopy.js needs to be renamed to be frozenCopy-test.js. The -test.js suffix is what makes the test file auto-run.

@jamiebuilds
Copy link
Contributor Author

@stefanpenner that's a suite, it gets pulled in by other tests.

@stefanpenner
Copy link
Member

@stefanpenner that's a suite, it gets pulled in by other tests.

Ah good catch. Whats blocking that last checkbox?

@jamiebuilds
Copy link
Contributor Author

Ah good catch. Whats blocking that last checkbox?

Me trying to finish my conference talk for next week. 😛

@stefanpenner
Copy link
Member

Me trying to finish my conference talk for next week.

ah ok. Carryon

@stefanpenner
Copy link
Member

cc @rwjblue

@rwjblue rwjblue self-assigned this Jun 26, 2015
@stefanpenner
Copy link
Member

@rwjblue friendly reminder

@jamiebuilds
Copy link
Contributor Author

Updated

stefanpenner added a commit that referenced this pull request Jul 16, 2015
@stefanpenner
Merge pull request #11468 from thejameskyle/tjk/deprecate-freezable
7d15fbc 
[BUGFIX release] Deprecate Freezable and frozenCopy. Resolves #11452
@stefanpenner stefanpenner merged commit 7d15fbc into emberjs:master Jul 16, 2015
@jamiebuilds jamiebuilds deleted the tjk/deprecate-freezable branch July 16, 2015 19:41
This was referenced Aug 4, 2015
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwjblue rwjblue

Labels
Needs Team Discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamiebuilds @mixonic @stefanpenner @rwjblue